# HG changeset patch # User Emmanuel Gil Peyrot # Date 1298208769 -3600 # Node ID 741110cdcfcfc62ecad7c3a7f74a7d72c71ad50c # Parent 4c808bfe06586005675bf41c79ee6404d3a9ac7e Avoid exposing unneeded object. diff --git a/errors.js b/errors.js --- a/errors.js +++ b/errors.js @@ -176,42 +176,39 @@ errors.owner = { }, }; -errors.reverse = {}; +var reverse = {}; -function reverseError(o) { +(function reverseError(o) { for (var i in o) { if (i == 'reverse' || typeof (o[i]) == 'number'); else if (!o[i].n) reverseError(o[i]); else { var k = {}; - //var k = {name: i}; for (var j in o[i]) { if (j != 'n') k[j] = o[i][j]; } - errors.reverse[o[i].n] = k; + reverse[o[i].n] = k; } } -} - -reverseError(errors); +})(errors); exports.makeError = function(response, errorNumber, payload) { response.attr.type = 'error'; if (payload) response.cnode(payload); - var e = errors.reverse[errorNumber]; + var e = reverse[errorNumber]; response.c('error', {type: e.type}); response.c(e.error, {xmlns: 'urn:ietf:params:xml:ns:xmpp-stanzas'}).up(); if (e.reason) { if (e.feature) - response.c(e.reason, {xmlns: 'http://jabber.org/protocol/pubsub#errors', feature: e.feature}).up(); + response.c(e.reason, {xmlns: 'http://jabber.org/protocol/pubsub#errors', feature: e.feature}); else - response.c(e.reason, {xmlns: 'http://jabber.org/protocol/pubsub#errors'}).up(); + response.c(e.reason, {xmlns: 'http://jabber.org/protocol/pubsub#errors'}); } return response;